[PATCH v3 0/5] Waf: Semi-automatic generation of results for cross-answers files

Andrew Bartlett abartlet at samba.org
Wed May 20 03:18:42 MDT 2015


On Wed, 2015-05-20 at 11:39 +0300, Alexander Bokovoy wrote:
> On Tue, May 19, 2015 at 12:17:36PM +0300, Uri Simchoni wrote:
> > Thanks for reviewing. Hre's version 5 with the following:
> > 
> > v5 1/10, 2/10/, 3/10 --> same as v4 1/5 but split to differentiate bug
> > fixes from the added feature
> > v5 4/10 --> same as v4 2/5
> > v5 5/10 --> a new bugfix to cross-execute (found thanks to Alexander's
> > insistence on providing something really useful and not some sample to
> > build upon)
> > v5 6/10 --> same as v4 3/5
> > v5 7/10 --> new version of v4 4/5 sample cross-execute program, making
> > it more configurable,
> >                  better documentation of usage and assumptions
> > v5 8/10, 9/10, 10/10 --> same as v4 5/5, but split to ease review
> Thanks for the patch, this is great contribution.
> 
> ACK to all patches in the patchset.
> 
> Can I have another team member review, please?

Done.  I've reviewed those and they are in the queue for autobuild now.

Thanks!

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list