[PATCH/RFC] Use submodule for dnspython

Jeremy Allison jra at samba.org
Wed May 13 11:12:31 MDT 2015

On Sat, May 09, 2015 at 11:24:29PM +0000, Jelmer Vernooij wrote:
> TL;DR: This patch removes our copy of dnspython from the tree and instead
> puts a submodule in place.
> Benefits
> ========
> This should make updates of external libraries (just dnspython for
> now) easier to review in the future as you'll just see a one-line diff
> updating it to a new upstream SHA. This way we can also easily verify we don't
> have any local changes.
> We currently use a mirror of the upstream dnspython repository that is
> hosted on git.samba.org - just in case upstream changes their URL.
> What changes for users
> ======================
> A consequence of this is that if "dnspython" is not installed on the
> system and if samba wasn't cloned using 'git clone --recursive',
> the user will get the following message during configure:
>   ERROR: Unable to find Python module 'dnspython'. Please install the
>   system package or check out the relevant submodule by running
>   'git submodule update --init'.
> (Previously Samba would automatically use the bundled version)
> This patchset won't apply with patch (it's got the
> contents of the removed files excluded so this e-mail won't exceed
> the byte limit for samba-technical), and is also available from the
> 'sumodule-dnspython' branch on git://git.samba.org/jelmer/samba.git

Can you send it to me directly ? I also think once this is in
we need to update the docs on:




More information about the samba-technical mailing list