[PATCH] namequery: suppress bogus warning "resolve_name: unknown name switch type"
urisimchoni at gmail.com
Wed May 13 03:38:29 MDT 2015
I think your approach is better. Do note that removal of the nbt resolvers
must occur after allocating the stack frame.
What do you think of the root cause? Would you agree that the fallback in
ads_find_dc() needs fixing too?
On Wed, May 13, 2015 at 9:58 AM, Volker Lendecke <Volker.Lendecke at sernet.de>
> On Wed, May 13, 2015 at 06:55:58AM +0300, Uri Simchoni wrote:
> > This patch fixes a warning that gets issued if NBT name resolving
> > methods are attempted on a name that cannot be an NBT name (e.g.
> > longer than 15 characters).
> This patch is entirely correct. Reviewed-by: Me.
> Attached find an alternative approach: Instead of
> introducing yet another boolean flag filter_out_nbt_lookup
> makes us skip the corresponding lookup flavors right away.
> It also removes the warning.
> A few more lines than your patch, but from my point of view
> less complexity.
> What do you think?
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical