Emailing: 0001-Add-IPv6-support-to-ADS-client-side-LDAP-connects.-C.patch

[David Holder]

------------------------------------------------------------------------
Dr David Holder CEng FIET MIEEE

Erion Ltd, An Cala, Inverkirkaig, Lochinver, Sutherland, IV27 4LR, UK

Reception: +44 (0)1422 207000

Direct Dial: +44 (0)131 2026317

http://www.erion.co.uk


Registered in England and Wales. Registered Number 3521142
Registered Office: Newtons, 49 Coniscliffe Road, Darlington, County 
Durham, DL3 7EH, UK
VAT Number: GB 698 3633 78

On 12/05/2015 18:44, Ralph Böhme wrote:
> On Tue, May 12, 2015 at 10:23:24AM -0700, Jeremy Allison wrote:
>> On Tue, May 12, 2015 at 04:27:03PM +0100, David Holder wrote:
>>> Hi All,
>>>
>>> The attached patch fixes a bug in Samba whereby client ADS LDAP
>>> connections fail to IPv6-only DCs.
>>>
>>> The fault was that the code assumed that a URI containing a literal
>>> IPv6 address has the same format as a URI containing a literal IPv4
>>> address in it. This assumption is wrong. For IPv6 URIs, the address
>>> must be enclosed in square brackets.
>>>
>>> E.g:
>>>
>>> ldap://192.168.1.1
>>> ldap://[2045::1]
>>>
>>> Please review - thanks!
>> Reviewed with minor change (attached)
>>
>> strstr(name, ":") doesn't
>> cope with utf8 names.
>>
>> strchr_m(name, ':')
Thanks Jeremy, I'll keep this in mind for any future patches.
>>
>> does. Also added your 'Signed-off-by:'
>>
>> With that LGTM. Can I get a second
>> Team reviewer please ?
> rb: me.
>
> -Ralph
Thanks Ralph.
>