Emailing: 0001-Add-IPv6-support-to-ADS-client-side-LDAP-connects.-C.patch

[Jeremy Allison]

On Tue, May 12, 2015 at 04:27:03PM +0100, David Holder wrote:
> Hi All,
> 
> The attached patch fixes a bug in Samba whereby client ADS LDAP
> connections fail to IPv6-only DCs.
> 
> The fault was that the code assumed that a URI containing a literal
> IPv6 address has the same format as a URI containing a literal IPv4
> address in it. This assumption is wrong. For IPv6 URIs, the address
> must be enclosed in square brackets.
> 
> E.g:
> 
> ldap://192.168.1.1
> ldap://[2045::1]
> 
> Please review - thanks!

Reviewed with minor change (attached)

strstr(name, ":") doesn't
cope with utf8 names.

strchr_m(name, ':')

does. Also added your 'Signed-off-by:'

With that LGTM. Can I get a second
Team reviewer please ?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-IPv6-support-to-ADS-client-side-LDAP-connects.-C.patch
Type: text/x-diff
Size: 1104 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150512/fa1f1e7b/attachment.patch>