[PATCH] Remove IPv4 only structures and controls

Jeremy Allison jra at samba.org
Mon May 11 16:42:37 MDT 2015


On Sun, May 10, 2015 at 11:37:00AM +1000, Amitay Isaacs wrote:
> 
> On Sat, Apr 18, 2015 at 2:32 AM, Jeremy Allison <jra at samba.org> wrote:
>      On Wed, Apr 01, 2015 at 11:19:38AM +1100, Amitay Isaacs wrote:
>      > Hi,
>      >
>      > Here are the two patches that remove IPv4 only structures and
>      obsolete ctdb
>      > controls.
>      >
>      > 1. Remove ctdb_control_tcp structure and use ctdb_control_tcp_addr
>      always.
>      >
>      > 2. Remove the code for ctdb controls GET_NODEMAPv4, TAKEOVER_IPv4,
>      > RELEASE_IPv4, GET_PUBLIC_IPSv4.
>      >
>      > Please review/push.
> 
>      Amitay,
> 
>      I was reviewing this - LGTM (I always like to see code
>      deleted :-) but it no longer applies cleanly to master
>      (some code already got deleted I think).
> 
>      Can you rebase and resend ?
> 
>      Thanks !
> 
>      Jeremy
> 
> Hi Jeremy,
> 
> Here are the updated patches that apply to master.

LGTM thanks - pushed !


More information about the samba-technical mailing list