[PATCH] some cleanups

[Volker Lendecke]

On Fri, May 08, 2015 at 09:36:45AM -0700, Jeremy Allison wrote:
> On Fri, May 08, 2015 at 04:46:41PM +0200, Volker Lendecke wrote:
> > Hi!
> > 
> > Review&push appreciated!
> > 
> > Thanks,
> > 
> > Volker
> > -					hex_encode(lm_key.data,
> > -						   lm_key.length,
> > -						   &hex_lm_key);
> > +					char hex_lm_key[lm_key.length*2+1];
> > +					hex_encode_buf(buf, lm_key.data,
> > +						       lm_key.length);
> >  					mux_printf(mux_id, "LANMAN-Session-Key: %s\n", hex_lm_key);
> > -					SAFE_FREE(hex_lm_key);
> 
> I think the:
> 
> > +                                     hex_encode_buf(buf, lm_key.data,
> > +                                                    lm_key.length);
> 
> should be:
> 
> > +                                     hex_encode_buf(hex_lm_key, lm_key.data,
> > +                                                    lm_key.length);
> 
> Can you confirm ? Other than that LGTM.

Crap. Two bad patches in a week. Probably I need some
vacation :-)

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de