Heimdal Patches Re: [PATCH] Some coverity fixes

Andrew Bartlett abartlet at samba.org
Sat May 9 01:07:38 MDT 2015

On Thu, 2015-05-07 at 17:39 +0200, Stefan (metze) Metzmacher wrote:
> Am 06.05.2015 um 13:01 schrieb Volker Lendecke:
> > On Wed, May 06, 2015 at 06:53:02AM -0400, Ira Cooper wrote:
> >> I have my questions about the heimdal fix on two levels.
> >>
> >> 1. Has it been upstreamed to Heimdal?
> > 
> > No. Upstream heimdal is dead. No release for more than 3
> > years, not even a security point release.
> There's quite some activity lately including coverity fixes,
> see:
> https://github.com/heimdal/heimdal/commits/master
> http://repo.or.cz/w/heimdal.git
> I'd just push fixes to our copy, we already have some extra patches.
> Before a possible rebase on heimdal master we need to check our extra
> patches anyway, so a few more won't hurt...

Actually, they really do hurt.  I am working on updating Heimdal (it is
a long, thankless task, but still clearly required), I've had to drop
almost all of the 'fix the build' patches so far, because they simply
don't apply.  

To ensure we don't just loose them when we rebase (and the rebase is
going to be so large you would never notice), I really do need patches
to Heimdal to be first submitted as github pull requests into Heimdal
master.  We have tools to try and pick up the local patches, but they
are no longer very helpful because we have a mix of patches that do
apply, don't apply upstream divergence or are already upstream.


Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list