Build error in http.c in new Fedora

[Ira Cooper]

Steve,

I'm running F22, on my main laptop, all looks well, on master, v4-2-test,
and v4-2-stable, but my machine is not stock, by any stretch ;).

If you want reproducible builds on Fedora or RHEL, I'd recommend looking
into mock.  It is the way the real packages are built, and you should be
able to build nearly identical packages barring small things like
timestamps etc.  (Hostnames... other things like that, that can get etched
in the binaries.)

Also it means you don't need a separate VM to do builds for RHEL/CentOS 6,
RHEL/CentOS 7, F20, F21, F22.

I'd recommend starting with installing "fedpkg" and working from there, on
Fedora.

-Ira

On Thu, May 7, 2015 at 5:49 PM, Steve French <smfrench at gmail.com> wrote:

> FYI - Noticed a build error on samba 4-2 with Fedora FC22 (clean
> system with only yum build-dep for Samba and plain boring ./configure
> ; make). .  I don't remember seeing this before but it looks like the
> code is wrong in changeset
>
> commit 8260ae6dbe5e65033d406ba26bbe97a6e4712c4c
> Author: Samuel Cabrero <samuelcabrero at kernevil.me>
> Date:   Tue Sep 16 16:12:26 2014 +0200
>
>     ncacn_http: Add http library
>
>     Signed-off-by: Samuel Cabrero <samuelcabrero at kernevil.me>
>
>
> Build error is:
>
> [sfrench at localhost samba]$ make
> WAF_MAKE=1 python ./buildtools/bin/waf build
> Waf: Entering directory `/home/sfrench/samba/bin'
> Selected embedded Heimdal build
> [1684/4078] Compiling source4/lib/http/http.c
> ../source4/lib/http/http.c: In function ‘http_parse_headers’:
> ../source4/lib/http/http.c:115:19: error: format ‘%a’ expects argument
> of type ‘float *’, but argument 3 has type ‘char **’ [-Werror=format=]
>   n = sscanf(line, "%a[^:]: %a[^\r\n]\r\n", &key, &value);
>                    ^
> ../source4/lib/http/http.c:115:19: error: format ‘%a’ expects argument
> of type ‘float *’, but argument 4 has type ‘char **’ [-Werror=format=]
> ../source4/lib/http/http.c: In function ‘http_parse_response_line’:
> ../source4/lib/http/http.c:161:19: error: format ‘%a’ expects argument
> of type ‘float *’, but argument 3 has type ‘char **’ [-Werror=format=]
>   n = sscanf(line, "%a[^/]/%c.%c %d %a[^\r\n]\r\n",
>                    ^
> ../source4/lib/http/http.c:161:19: error: format ‘%a’ expects argument
> of type ‘float *’, but argument 7 has type ‘char **’ [-Werror=format=]
> cc1: some warnings being treated as errors
> Waf: Leaving directory `/home/sfrench/samba/bin'
> Build failed:  -> task failed (err #1):
> {task: cc http.c -> http_1.o}
> Makefile:8: recipe for target 'all' failed
> make: *** [all] Error 1
> [sfrench at localhost samba]$ git branch -a
>   master
> * v4-2-stable
>   remotes/origin/HEAD -> origin/master
>
>
> --
> Thanks,
>
> Steve
>