[PATCH] some O3 developer build fixes

Stefan (metze) Metzmacher metze at samba.org
Wed May 6 08:03:11 MDT 2015


Am 06.05.2015 um 15:54 schrieb Volker Lendecke:
> On Wed, May 06, 2015 at 03:52:17PM +0200, Stefan (metze) Metzmacher wrote:
>> Hi Volker,
>>
>>> This contains the controversial heimdal fix along with a
>>> heimdal O3 developer build fix on Solaris. I've pushed the
>>> rest from that former patchset with Ira's R-B.
>>>
>>> If we decide to not touch heimdal at all anymore, we need to
>>> excempt it from all build errors that come from warnings.
>>>
>>> waf gurus: Where would I apply such an excemption?
>>
>> That should already be the case.
>> HEIMDAL_SUBSYSTEM() uses allow_warnings=True.
>>
>> What errors are you seeing?
> 
> It was an unitialized variable warning in heimdal that we
> now treat as an error in the configure.developer build.

Ah, the -Werror=uninitialized.

We could remove that keep only -Wuninitialized
and rely on the --picky-developer option (the default in autobuild)
to add -Werror and trigger errors.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150506/ab5471ae/attachment.pgp>


More information about the samba-technical mailing list