[PATCH] Some coverity fixes

[Volker Lendecke]

On Wed, May 06, 2015 at 09:35:28PM +1000, Dewayne Geraghty wrote:
> On 6/05/2015 9:01 PM, Volker Lendecke wrote:
> > On Wed, May 06, 2015 at 06:53:02AM -0400, Ira Cooper wrote:
> >> I have my questions about the heimdal fix on two levels.
> >>
> >> 1. Has it been upstreamed to Heimdal?
> > No. Upstream heimdal is dead. No release for more than 3
> > years, not even a security point release.
> >
> >> 2. I'm not sold it is right either... that code looks horrible.
> > So what shall we do? Rewrite it to look saner?
> >
> > Volker
> >
> Volker,
> The comment "Upstream heimdal is dead" was so disconcerting that I went
> looking at http://repo.or.cz/w/heimdal.git
> 
> I was surprised to find a heimdal 1.5.3?  I suspect that they need more

Come on, heimdal 1.5.3 is more than 2 years old according to that source,
and 1.6 lingers in rc state for more than a year. Samba might be bad
with timely releases, but this is just the definition of being orphanware.

> community support for communicating that the development is ongoing - up
> to 6 days ago :)

My guess is that heimdal is an Apple only show and that all release
management is done inside Apple. For any non-Apple use heimdal is just
no option anymore. There are quite some people working on getting rid
of heimdal in Samba, but this will take a while and until then I think
we should just patch what we have.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de