[PATCH] Some coverity fixes
ira at samba.org
Wed May 6 05:46:12 MDT 2015
On Wed, May 6, 2015 at 7:01 AM, Volker Lendecke <Volker.Lendecke at sernet.de>
> On Wed, May 06, 2015 at 06:53:02AM -0400, Ira Cooper wrote:
> > I have my questions about the heimdal fix on two levels.
> > 1. Has it been upstreamed to Heimdal?
> No. Upstream heimdal is dead. No release for more than 3
> years, not even a security point release.
So what is our policy here... ? I've had other heimdal fixes suggested to
me, but I've declined them due to mail from Andrew last year when the RHS
team starrted to do coverity work.
> > 2. I'm not sold it is right either... that code looks horrible.
> So what shall we do? Rewrite it to look saner?
No... but you are taking a deltat type to time_t... and I'm nervous signing
it off without a more complete understanding... I'll admit, you likely
aren't making it worse.
A quick look still has me nervous, alas. Note, this is not a NACK. It is
a 0. I'm not sure what to think.
More information about the samba-technical