[PATCH] Fix bug #11249 - Mangled names do not work with acl_xattr - version 2.
Ralph Böhme
rb at sernet.de
Mon May 4 22:56:29 MDT 2015
On Mon, May 04, 2015 at 08:48:16PM -0700, Jeremy Allison wrote:
> On Mon, May 04, 2015 at 10:29:02PM +0200, Andreas Schneider wrote:
> > On Monday 04 May 2015 12:39:30 Jeremy Allison wrote:
> > > Please review and/or push !
> >
> > Could you please add 'BUG: ' infront of the bugzilla urls? Thanks :)
> >
> > Then you have my RB+
>
> Andreas,
>
> Here is the updated version of the patchset that now passes
> the raw.streams tests. Sorry for the error, it turned out
> to be a code path in the vfs_fake_acl module that was passing
> stream pathnames to XATTR calls (what I've been removing in
> the other code :-) and once the XATTR code was changed to stop
> it from filtering out the stream name it caused OBJECT_NOT_FOUND
> errors. vfs_fake_acl is not used in production, only in the
> test rig so that's why I missed it :-(.
>
> I've added the 'BUG: ' in the bugzilla URLs, and
> the only other change from the previous patchset was the
> addition of the patch:
>
> -----------------------------------------------------
> s3: smbd: VFS: fake_acl module called get_full_smb_filename()
> with a stream path, then used the result to call XATTR functions directly.
>
> Ensure when pulling XATTR values, we don't allow a stream filename.
> -----------------------------------------------------
>
> which fixed the streams tests.
>
> If you could review that additional change I'd appreciate it.
I'd apprecieate if I could get enough time to test and ensure this
works with vfs_fruit and it's stacking with vfs_catia too.
Thanks!
-slow
More information about the samba-technical
mailing list