[PATCH] Fix bug #11249 - Mangled names do not work with acl_xattr - version 2.

Andrew Bartlett abartlet at samba.org
Mon May 4 22:23:21 MDT 2015


On Mon, 2015-05-04 at 20:48 -0700, Jeremy Allison wrote:
> On Mon, May 04, 2015 at 10:29:02PM +0200, Andreas Schneider wrote:
> > On Monday 04 May 2015 12:39:30 Jeremy Allison wrote:
> > > Please review and/or push !
> > 
> > Could you please add 'BUG: ' infront of the bugzilla urls? Thanks :)
> > 
> > Then you have my RB+
> 
> Andreas,
> 
> Here is the updated version of the patchset that now passes
> the raw.streams tests. Sorry for the error, it turned out
> to be a code path in the vfs_fake_acl module that was passing
> stream pathnames to XATTR calls (what I've been removing in
> the other code :-) and once the XATTR code was changed to stop
> it from filtering out the stream name it caused OBJECT_NOT_FOUND
> errors. vfs_fake_acl is not used in production, only in the
> test rig so that's why I missed it :-(.

Jeremy,

I'm very, very glad vfs_fake_acl isn't used in production, it's a one
the more horrid hacks I had to put in to get testing of the full ACL
stack :-)

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list