[PATCH v2 0/3] Waf: Semi-automatic generation of results for cross-answers files

[Uri Simchoni]

Hi,

Thanks for reviewing.

On Mon, May 4, 2015 at 5:14 AM, Andrew Bartlett <abartlet at samba.org> wrote:

> On Mon, 2015-05-04 at 00:38 +0300, Uri Simchoni wrote:
> > This patchset automates the generation of cross-answers file for
> cross-compiling
> > samba. It takes a different approach than the first version of the patch,
> > namely that instead of cacheing the built tests and run them later in one
> > batch, it runs each test immediately using the cross-execute parameter.
>
<snip>

>
> Thanks for all your efforts on this.  To ensure this doesn't bitrot, we
> need a patch to autobuild.py, that uses this new mode, somehow
> cross-compiling Samba for it's own arch.
>

What I have in mind is as follows (have given it a quick test, seems to
work):
1. Run configure (same params as the configure step in samba build)
2. Run configure again with -b cc_bin --cross-compile
--cross-execute=identity_cc.sh --cross-answers=./cc_bin/cross_answers.txt
3. Run configure again with -b cc_bin2 --cross-compile
--cross-answers=./cc_bin/cross_answers.txt
4. Compare the bin/c4che/default.cache.py of run 1 and 3 (with some
sanitizing due to different build path and cross arguments)

identity_cc.sh would simply be:
#!/bin/sh
eval "$@"

The remaining question is where to put all this - in the samba task (taking
into consideration that a different configure affects make) or in its own
task.

How does that sound?


> Also, is there any reason why the sample should use telnet, not ssh?
>

I knew this was coming... :) It's just what I had available on the
particular platform I was developing this for. I suppose I can do ssh.

>
> Finally, the # comments need some stylistic improvement in the the first
> patch.
>

I'll have it pass pep8. anything beyond that?

> Thanks,
>
> Andrew Bartlett
>
> --
> Andrew Bartlett
> http://samba.org/~abartlet/
> Authentication Developer, Samba Team  http://samba.org
> Samba Developer, Catalyst IT
> http://catalyst.net.nz/services/samba
>
>
>
>
>