make install issue with "Update the copy of waf to current 1.5"

Jelmer Vernooij jelmer at samba.org
Sat May 2 04:51:38 MDT 2015


On Sat, May 02, 2015 at 09:36:47PM +1200, Andrew Bartlett wrote:
> On Fri, 2015-05-01 at 14:37 +0000, Jelmer Vernooij wrote:
> > On Fri, May 01, 2015 at 05:44:17PM +1200, Andrew Bartlett wrote:
> > > Thanks Adrian,
> > > 
> > > Jelmer,
> > > 
> > > I've looked with Adrian at the delta between what we have in third-party
> > > and the latest waf 1.5 release, and the differences are not what are
> > > mentioned in the commit (that I reviewed!).  That is, I can't see
> > > anything about LDVERSION or big changes in Python.py, but other files
> > > seem to have odd differences. 
> > The upstream change to add LDVERSION was reverted, meaning it is *not*
> > included in this commit.
> > 
> > What odd differences are you seeing?
> 
> Jelmer,
> 
> None of the differences looked like LDVERSION. 
Yes, that's expected. LDVERSION was added upstream (and wasn't present
in Samba's copy of waf), and we chose to not include that change when
we updated from upstream.

E.g. I ran:

* ran buildtools/bin/updatew-waf.sh
* revert staged changes for Python.py

Cheers,

Jelmer


More information about the samba-technical mailing list