[PATCH 0/2] libads: A couple of fixes for keytab generation

Jeremy Allison jra at samba.org
Fri May 1 18:20:56 MDT 2015

On Sat, May 02, 2015 at 12:35:26AM +0300, Uri Simchoni wrote:
> Fix a crash in "net ads keytab create" if the keytab file cannot be opened
> Fix a deadlock in "net ads join" if a keytab is updated
> Uri Simchoni (2):
>   libads: Fix free of uninitialized pointer
>   libads: Fix deadlock when re-joining a domain and updating keytab
>  source3/libads/kerberos_keytab.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

Uri - both of these look good to me. Can you send
in a certificate of origin as described here:


to contributing at samba.org.

PLus can you add your Signed-off-by: lines ?

Can I get a second Team reviewer please ?

Thanks a *LOT* - looks great work !



More information about the samba-technical mailing list