make install issue with "Update the copy of waf to current 1.5"

[Jelmer Vernooij]

On Fri, May 01, 2015 at 05:44:17PM +1200, Andrew Bartlett wrote:
> Thanks Adrian,
> 
> Jelmer,
> 
> I've looked with Adrian at the delta between what we have in third-party
> and the latest waf 1.5 release, and the differences are not what are
> mentioned in the commit (that I reviewed!).  That is, I can't see
> anything about LDVERSION or big changes in Python.py, but other files
> seem to have odd differences. 
The upstream change to add LDVERSION was reverted, meaning it is *not*
included in this commit.

What odd differences are you seeing?

Cheers,

Jelmer

> 
> On Fri, 2015-05-01 at 13:21 +1200, adrianc at catalyst.net.nz wrote:
> 
> > commit 2ab6c10f843c2bd703528bf5b753d8a74e97cf3a
> > Author: Jelmer Vernooij <jelmer at samba.org>
> > Date:   Sat Mar 7 15:31:17 2015 +0100
> > 
> >      Update the copy of waf to current 1.5
> > 
> >      After making the update, this commit reverts the upstream addition 
> > of
> >      LDVERSION support in Python.py, which is necessary for Python 3
> >      support in waf. This change conflicts with the last remaining
> >      Samba-specific change in waf to help with cross-compilation.
> > 
> >      Change-Id: Iedfdc0199e9d10dfbd910c4eab50c23f984b6e2d
> >      Signed-Off-By: Jelmer Vernooij <jelmer at samba.org>
> > 
> >      Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> > 
> > Bringing waf up to date appears to fix the issue.
> 
> Given this, what would break if we just re-sync with Waf 1.5 again?
> 
> Andrew Bartlett
> 
> -- 
> Andrew Bartlett
> http://samba.org/~abartlet/
> Authentication Developer, Samba Team  http://samba.org
> Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba
> 
> 
> 
>