[PATCH v4] File Server Remote VSS Protocol server

[Jeremy Allison]

On Mon, Mar 30, 2015 at 04:09:29PM +0200, David Disseldorp wrote:
> On Fri, 27 Mar 2015 21:28:20 -0700, Jeremy Allison wrote:
> 
> > On Fri, Mar 27, 2015 at 12:44:09PM +0100, David Disseldorp wrote:
> > > This patch-set adds a new File Server Remote VSS (Volume Shadow Copy
> > > Service) Protocol server, test infrastructure, documentation, and
> > > corresponding VFS layer changes to handle remote share snapshot
> > > requests.  
> > 
> > Pushed, with a minor cleanup in:
> > 
> > fsrvp: prune shadow copies if associated path doesn't exist
> 
> Thanks for the push. Looks like there's a build failure in the unit
> tests that I don't hit locally:
> 
> In file included from ../source4/torture/local/local.c:25:
> default/source4/torture/rpc/proto.h:22: error: 'struct policy_handle' declared inside parameter list
> default/source4/torture/rpc/proto.h:22: error: its scope is only this definition or declaration, which is probably not what you want
> default/source4/torture/rpc/proto.h:22: error: 'struct dcerpc_binding_handle' declared inside parameter list
> ...
> 
> The autogenerated torture/rpc/proto.h header isn't needed here anyway,
> as torture_local_fsrvp() is provided by torture/local/proto.h.
> 
> Please squash this patch:
> 
> diff --git a/source4/torture/local/local.c b/source4/torture/local/local.c
> index db729af..5d3b4e1 100644
> --- a/source4/torture/local/local.c
> +++ b/source4/torture/local/local.c
> @@ -22,7 +22,6 @@
>  #include "torture/local/proto.h"
>  #include "torture/ndr/proto.h"
>  #include "torture/auth/proto.h"
> -#include "torture/rpc/proto.h"
>  #include "../lib/crypto/test_proto.h"
>  #include "lib/registry/tests/proto.h"
>  #include "lib/replace/replace-testsuite.h"
> 
> ...into "torture: add local FSRVP server state tests"
> 
> Otherwise I can send the whole patch-set as a new round if you'd
> prefer.

No that's ok. Trying again with this change..