[PATCH] some cleanup
Volker Lendecke
Volker.Lendecke at SerNet.DE
Mon Mar 30 00:41:41 MDT 2015
Hi!
Review&push appreciated!
Thanks,
Volker
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From 8ad2796959ae803557a6bdda2ab0d28b676a3c3d Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Sun, 29 Mar 2015 15:59:41 +0200
Subject: [PATCH 1/3] heimdal: Fix a warning
99% this is what was meant....
Signed-off-by: Volker Lendecke <vl at samba.org>
---
source4/heimdal/lib/hcrypto/engine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/source4/heimdal/lib/hcrypto/engine.c b/source4/heimdal/lib/hcrypto/engine.c
index 3b22e56..2f34d6e 100644
--- a/source4/heimdal/lib/hcrypto/engine.c
+++ b/source4/heimdal/lib/hcrypto/engine.c
@@ -88,7 +88,7 @@ ENGINE_finish(ENGINE *engine)
if(engine->destroy)
(*engine->destroy)(engine);
- memset(engine, 0, sizeof(engine));
+ memset(engine, 0, sizeof(*engine));
engine->references = -1;
--
1.9.1
From 47ac97732ce84e3b4d4f9911ec465621f425b929 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Sun, 29 Mar 2015 15:59:41 +0200
Subject: [PATCH 2/3] heimdal: Fix a warning
99% this is what was meant....
Signed-off-by: Volker Lendecke <vl at samba.org>
---
source4/heimdal/lib/hcrypto/md2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/source4/heimdal/lib/hcrypto/md2.c b/source4/heimdal/lib/hcrypto/md2.c
index 26254ac..b6517a6 100644
--- a/source4/heimdal/lib/hcrypto/md2.c
+++ b/source4/heimdal/lib/hcrypto/md2.c
@@ -130,5 +130,5 @@ MD2_Final (void *res, struct md2 *m)
MD2_Update(m, pad, 16);
memcpy(res, m->state, MD2_DIGEST_LENGTH);
- memset(m, 0, sizeof(m));
+ memset(m, 0, sizeof(*m));
}
--
1.9.1
From b2f1bf69f3ae2d0b3c4fdb2c9f1a90d66ca213a3 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Sun, 29 Mar 2015 18:17:46 +0200
Subject: [PATCH 3/3] groupdb: Fix a typo
Signed-off-by: Volker Lendecke <vl at samba.org>
---
source3/groupdb/mapping_tdb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/source3/groupdb/mapping_tdb.c b/source3/groupdb/mapping_tdb.c
index e793ef3..c8156d9 100644
--- a/source3/groupdb/mapping_tdb.c
+++ b/source3/groupdb/mapping_tdb.c
@@ -101,7 +101,7 @@ static bool init_group_mapping(void)
vers_id = DATABASE_VERSION_V2;
}
- /* if its an unknown version we remove everthing in the db */
+ /* if its an unknown version we remove everything in the db */
if (vers_id != DATABASE_VERSION_V2) {
tdb_wipe_all(tdb);
--
1.9.1
More information about the samba-technical
mailing list