[PATCH v3] File Server Remote VSS Protocol server

[David Disseldorp]

Hi Jeremy,

I've sent out a new v4 patchset, which includes these corresponding
changes...

On Thu, 26 Mar 2015 16:13:34 -0700, Jeremy Allison wrote:

> ------------------------------------------------------------------
> 1).
> In static NTSTATUS snapper_create_snap_pack()
...
> *** MISSING****
> 		 talloc_free(enc_ctx); here.

Fixed.

...
> +       talloc_free(fss_global.seq_tmr);        /* kill timer if running */
> +       fss_seq_tout_set(fss_global.mem_ctx, 180, NULL, &fss_global.seq_tmr);
> 
> Use TALLOC_FREE(fss_global.seq_tmr) to ensure it's
> correctly NULL'ed out. If fss_seq_tout_set() fails
> then fss_global.seq_tmr is left with a bad pointer
> if you just call talloc_free().

Fixed.

> Right now I can't see any other issues at all !
> 
> *GREAT WORK* !!
> 
> I'm going to run a 'make test' and if all is well
> (I'll reply by tomorrow) please fix these and then
> push with my 'Reviewed-by:'.
> 
> Cheers and thanks a *LOT* for your patience on this !

Thanks a lot for feedback and support in moving these changes forward!

Cheers, David