[PATCH] Fix bug #11177 - no talloc stackframe at ../source3/libsmb/clifsinfo.c:444, leaking memory

Jeremy Allison jra at samba.org
Thu Mar 26 11:46:54 MDT 2015

On Thu, Mar 26, 2015 at 06:43:14PM +0100, Michael Adam wrote:
> The patch looks good, pushing.
> One comment:
> Somehow it feels awkward that all those SMBC_foo_ctx
> functions should have to create a talloc stackframe
> even if they don't need one themselves, just so that
> functions later in the call chain can be lazy.
> Can't this be done in a central place?
> (Or have I lost it completely?)

I don't think there's a central place for it, as
any user function can create a SMBC context
and then pass it around to other functions -
doesn't have to be a containing function.

I think we have most of them now though (fingers
crossed :-).

More information about the samba-technical mailing list