[PATCH] Fix bug #11177 - no talloc stackframe at ../source3/libsmb/clifsinfo.c:444, leaking memory

Michael Adam obnox at samba.org
Thu Mar 26 11:43:14 MDT 2015


The patch looks good, pushing.

One comment:

Somehow it feels awkward that all those SMBC_foo_ctx
functions should have to create a talloc stackframe
even if they don't need one themselves, just so that
functions later in the call chain can be lazy.
Can't this be done in a central place?
(Or have I lost it completely?)

Michael


On 2015-03-26 at 10:12 -0700, Jeremy Allison wrote:
> Pretty obvious, missing talloc stackframe in libsmbclient.
> 
> Confirmed by submitter.
> 
> Please review and push.
> 
> Cheers,
> 
> 	Jeremy

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150326/9ae83506/attachment.pgp>


More information about the samba-technical mailing list