[PATCH v2] File Server Remote VSS Protocol server

[Volker Lendecke]

On Tue, Mar 24, 2015 at 02:19:59PM +0100, David Disseldorp wrote:
> Thanks for the feedback Volker.
> 
> On Tue, 24 Mar 2015 13:37:11 +0100, Volker Lendecke wrote:
> 
> > On Mon, Mar 23, 2015 at 08:37:37PM +0100, David Disseldorp wrote:
> > > This patch-set adds a new File Server Remote VSS (Volume Shadow Copy
> > > Service) Protocol server, test infrastructure, documentation, and
> > > corresponding VFS layer changes to handle remote share snapshot
> > > requests.
> > 
> > As discussed privately already: This patchset adds a persistent tdb
> > for fss_state using tdb_pack/unpack.  tdb_pack/unpack is really a bad
> > interface that I'd like to get rid of eventually. In new code we do
> > marshalling of structures with idl/ndr usually. Can you change the code
> > to idl before it goes in? This way necessary upgrade code can be avoided?
> 
> I agree that tdb_pack/unpack is a pretty ugly interface, and I'm fine
> with using idl for [un]marshalling. As mentioned though, I don't think
> this should be a show-stopper for merging this feature - conversion to
> IDL should be possible without a change to the on-disk format.

Wouldn't this mean that we have to teach PIDL about the format
tdb_pack/unpack uses? The reason why I jumped on this is that this will be
another fresh piece of code that will have to be converted when someone
wants to get rid of tdb_pack. We already have data upgrade procedures
all over the place, for example in pdb_tdb. Whenever I look at those I
get the impression that we can never ever get rid of this code, although
it is neither well tested nor in use at all anywhere anymore. If we know
that we want to change the data format soon, I would hesitate to create
new data files with an already deprecated format.

> The database is only manipulated by the single FSRVP server process, so
> this shouldn't be an issue.

Ok, I did not see that this is single-process single thread.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de