[PATCH v2] File Server Remote VSS Protocol server

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Mar 24 06:37:11 MDT 2015

On Mon, Mar 23, 2015 at 08:37:37PM +0100, David Disseldorp wrote:
> This patch-set adds a new File Server Remote VSS (Volume Shadow Copy
> Service) Protocol server, test infrastructure, documentation, and
> corresponding VFS layer changes to handle remote share snapshot
> requests.

As discussed privately already: This patchset adds a persistent tdb
for fss_state using tdb_pack/unpack.  tdb_pack/unpack is really a bad
interface that I'd like to get rid of eventually. In new code we do
marshalling of structures with idl/ndr usually. Can you change the code
to idl before it goes in? This way necessary upgrade code can be avoided?

Also, looking a bit closer at fss_state_store: There's a dbwrap_wipe
without a transaction. Isn't that racy? Do we have an overview somewhere
about the data model stored in fss_state?



SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list