It is annoying that some of our OP definitions do not match MS-SMB2 ...

[Christopher R. Hertel]

Some of the SMB2 code was written prior to the release of the specification.

Another example would be the NTLM documentation that was developed for NTLM
over HTTP (http://davenport.sourceforge.net/ntlm.html).  That document was
by far the best reference available for years, and the terminology has
become somewhat standard.  Of course, it doesn't match Microsoft's
terminology...which drives them bonkers.  :)

Chris -)-----

On Mon, Mar 23, 2015 at 4:35 PM, Jeremy Allison <jra at samba.org> wrote:

> On Mon, Mar 23, 2015 at 02:34:40PM -0700, Richard Sharpe wrote:
> > Hi folks,
> >
> > For example:
> >
> >         case SMB2_OP_FIND:
> >
> > which should really be:
> >
> >         case SMB2_OP_QUERY_DIRECTORY:
> >
> > There's another as well.
>
> Well you know what to do...
>
> git format-patch --stdout ... :-).
>



-- 
"Implementing CIFS - the Common Internet FileSystem" ISBN: 013047116X
Samba Team -- http://www.samba.org/     -)-----   Christopher R. Hertel
jCIFS Team -- http://jcifs.samba.org/   -)-----   ubiqx development, uninq.
ubiqx Team -- http://www.ubiqx.org/     -)-----   crh at ubiqx.mn.org
OnLineBook -- http://ubiqx.org/cifs/    -)-----   crh at ubiqx.org