[PATCH] Fix bug 11175 - Lots of winbindd zombie processes on Solaris platform

Jeremy Allison jra at samba.org
Mon Mar 23 15:29:50 MDT 2015


On Mon, Mar 23, 2015 at 10:24:36PM +0100, Volker Lendecke wrote:
> On Mon, Mar 23, 2015 at 02:09:35PM -0700, Jeremy Allison wrote:
> >  
> > +static void (*tdb_robust_mutex_setup_sigchild(void (*handler)(int)))(int)
>                ^                                                      ^
> 
> Is this set of braces really necessary?

Compiler says yes :-).

> > -	signal(SIGCHLD, tdb_robust_mutext_old_handler);
> > +	(void)tdb_robust_mutex_setup_sigchild(tdb_robust_mutext_old_handler);
> 
> And this (void)? Is that necessary?

Compiler says no, so no :-).

> >  cleanup_sig_child:
> > -	signal(SIGCHLD, tdb_robust_mutext_old_handler);
> > +	(void)tdb_robust_mutex_setup_sigchild(tdb_robust_mutext_old_handler);
> 
> Here too.

As above..

Updated version attached...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lib-tdb-Use-sigaction-when-testing-for-robust-mutexe.patch
Type: text/x-diff
Size: 2330 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150323/28d50e47/attachment.patch>


More information about the samba-technical mailing list