[PATCH] Coverity fix (CID 1272947)
Michael Adam
obnox at samba.org
Mon Mar 23 08:49:37 MDT 2015
LGTM - pushing
On 2015-03-23 at 18:10 +0530, Anoop C S wrote:
> Hi
>
> Please find the attached coverity fix.
> Waiting for reviews.
>
> --Anoop C S.
> >From d9a51c44b27ecfad9506dff6053cbfd4ba7831a9 Mon Sep 17 00:00:00 2001
> From: Anoop C S <achiraya at redhat.com>
> Date: Mon, 23 Mar 2015 17:11:31 +0530
> Subject: [PATCH] libnetapi: Fix CID 1272947 Fix logically dead code
>
> Signed-off-by: Anoop C S <achiraya at redhat.com>
> Reviewed-by: Guenther Deschner <gd at samba.org>
> ---
> source3/lib/netapi/samr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/source3/lib/netapi/samr.c b/source3/lib/netapi/samr.c
> index 7b3d3c5..97c61d1 100644
> --- a/source3/lib/netapi/samr.c
> +++ b/source3/lib/netapi/samr.c
> @@ -45,7 +45,7 @@ WERROR libnetapi_samr_open_domain(struct libnetapi_ctx *mem_ctx,
> struct samr_SamArray *sam = NULL;
> const char *domain_name = NULL;
> struct lsa_String lsa_domain_name;
> - bool domain_found = true;
> + bool domain_found = false;
> int i;
> struct dcerpc_binding_handle *b = pipe_cli->binding_handle;
>
> --
> 2.1.0
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150323/2100b0eb/attachment.pgp>
More information about the samba-technical
mailing list