[PATCHES] ctdb reloadnodes improvements

Amitay Isaacs amitay at gmail.com
Sun Mar 22 23:58:20 MDT 2015

Hi Martin,

On Sat, Mar 21, 2015 at 3:18 PM, Martin Schwenke <martin at meltin.net> wrote:

> This is the first half of some enhancements to the "ctdb reloadnodes"
> command.  It adds:
> * Cross-node comparison of nodes files to ensure they are all the
>   same.
>   This avoids having different nodes running with different nodes lists
>   and causing chaos.
> * Various sanity checks, including that the new nodes file has nodes
>   with the same IP addresses as the active nodes list and that deleted
>   nodes are disconnected.
>   This avoids errors like removing a line for a deleted node rather
>   than commenting it out, and accidentally leaving deleted nodes
>   connected.
> There are a couple of test fixes/improvements at the top of the
> series.  The series also adds many unit tests for "ctdb reloadnodes".
> There is more to come in the next series.  For example, explicitly
> disabling recovery, node consistency checks before doing "ctdb
> reloadnodes" and a bunch of cleanups.  However, this first patch series
> can stand alone so can be reviewed separately.
> I won't attach the patches because then the message size will exceed the
> moderation limit on the list, so please see the top 20 commits (on top
> of master) in:
> https://git.samba.org/?p=martins/samba.git;a=shortlog;h=refs/heads/ctdb-reloadnodes
>   git://git.samba.org/martins/samba.git (ctdb-reloadnodes branch)
> Review and push appreciated.  Thanks!

Following patch adds an unused variable "i" in function
ctdb_get_nodes_files().  I have fixed that and pushed to autobuild.

   ctdb-tools: Add cross-node file comparison to "reloadnodes"


More information about the samba-technical mailing list