[PATCHSET] Cleanup KDC code
jra at samba.org
Fri Mar 20 16:06:05 MDT 2015
On Thu, Mar 19, 2015 at 08:43:36AM +0100, Andreas Schneider wrote:
> On Wednesday 18 March 2015 21:21:03 Stefan Metzmacher wrote:
> > Am 18.03.2015 um 07:22 schrieb Andreas Schneider:
> > > On Wednesday 18 March 2015 17:16:05 Andrew Bartlett wrote:
> > >> I've not had time for a full review, but at the same time I didn't see
> > >> anything particularly odd or unexpected.
> > >>
> > >> The only thing I would like is to have the krb5.kdc tests extended to
> > >> verify that encryption order, by having it parse the relevant packets
> > >> and asserting on those values.
> > >>
> > >> (Otherwise, a 'cleanup' later might change the order, or fail to enable
> > >> an AES key when we should, and we might never notice we were below full
> > >> strength).
> > >
> > > Thanks, please push the patches which you think are fine. I will look into
> > > writing a test with Günther.
> > I have these patches in my master4-forest-tmp branch
> > with one improvement for "s4-kdc/db_glue: use
> > smb_krb5_principal_get_realm()."
> > https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=5ed268d68f950c7e
> > 83e6cecfd1e9f87be0ef1432
> Thanks, I've squashed it.
> > and a question regarding "samba_dnsupdate: Use selftest krb5.conf."
> > https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=45b7aa7624cabda0
> > e5f3987a0b935e87813b9e5a
> Take a look here:
Hi Andreas, can you repost the current
version of this patchset on the list please
so it can get reviewed and in ?
I was planning to do it - they mostly
look really good (I wrote a lot of the
krb5 wrapper stuff a long time ago :-) !
More information about the samba-technical