[PATCH] mark tombstone_reanimation patch flapping

Andrew Bartlett abartlet at samba.org
Fri Mar 20 12:18:38 MDT 2015


On Fri, 2015-03-20 at 14:40 +0200, Kamen Mazdrashki wrote:
> Hi Andrew,
> 
> Sorry for delay, I didn't do anything yesterday - just fall asleep all of a
> sudden.
> I think both delete_object and tombstone_reanimation tests interfere with
> replication.
> As far as I can recall, the idea for all those tests was to pause
> replication during
> the test. We haven't had implementation in place to pause replication back
> then
> and imo we don't have it now too.

Yes, replication can be stopped, but can you give a theory as to how
replication causes an issue in tombstone_reanimation?  

The delete_object test does manipulate replication, indeed, that is the
purpose of the test.

The dbcheck failures I wasn't previously aware of - it is one thing to
have the wrong state after a conflict in delete or not, it is entirely
another to get that state wrong enough that dbcheck can notice.  This
may give some insight. 

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list