[PATCH] mark tombstone_reanimation patch flapping
Michael Adam
obnox at samba.org
Wed Mar 18 11:42:43 MDT 2015
Ok.... we tried to add the tests to
flapping with maximum precision, i.e. referencing the
subtests that fail. But this does not seem to have worked:
https://git.samba.org/autobuild.flakey/2015-03-18-1659/samba.stdout
So here is the follow-up patchset that broadens
the flapping to the whole test-suites.
Review/push appreciated..
Michael
On 2015-03-18 at 10:38 +0100, Michael Adam wrote:
> Pushing after ACK from metze on a side-channel.
>
> On 2015-03-18 at 10:08 +0100, Michael Adam wrote:
> > Attached.
> >
> > On 2015-03-18 at 09:25 +0100, Michael Adam wrote:
> > > On 2015-03-18 at 09:05 +0100, Stefan (metze) Metzmacher wrote:
> > > > Am 17.03.2015 um 23:07 schrieb Michael Adam:
> > > > > Hi,
> > > > >
> > > > > it seems that the tombstone_reanimation test is the most
> > > > > prominent flapping test currently. I keeps us busy resubmitting
> > > > > autobuilds... Apparently the checks added in
> > > > > 72998acc451a8722f19b901a9948774de089921a fail randomly.
> > > > >
> > > > > Can we mark this test flapping until this has been fixed?
> > > >
> > > > Please include an example output of the failing autobuild into
> > > > the commit message.
> > > >
> > > > Otherwise I'm fine with the change.
> > >
> > > preparing...
> > >
> > > > I'd also propose to add
> > > > samba4.drs.delete_object.python(promoted_dc)(promoted_dc)
> > > >
> > > > See https://git.samba.org/autobuild.flakey/2015-03-18-0813/samba.stdout:
> > >
> > > good point, preparing that as well...
> > >
> > > Thanks - Michael
-------------- next part --------------
From 396d7aa5e8f078aca95975c0e9e5e2920c5f3964 Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Wed, 18 Mar 2015 17:41:11 +0100
Subject: [PATCH 1/2] selftest: fix the flapping entry for the tombstone
reanimation test
Signed-off-by: Michael Adam <obnox at samba.org>
---
selftest/flapping | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/selftest/flapping b/selftest/flapping
index 17f5048..5e37a1b 100644
--- a/selftest/flapping
+++ b/selftest/flapping
@@ -25,5 +25,5 @@
^samba3.raw.acls.inheritance\(ad_dc\) # Seems to flap - succeeds on sn-devel, fails on Fedora 16
^samba3.raw.samba3checkfsp.samba3checkfsp\(ad_dc\) # Seems to flap - succeeds on sn-devel, fails on Fedora 16
^samba3.raw.samba3closeerr.samba3closeerr\(ad_dc\) # Seems to flap - succeeds on sn-devel, fails on Fedora 16
-^samba4.tombstone_reanimation.python.tombstone_reanimation.RestoreContainerObjectTestCase.test_container # flakey on sn-devel
+^samba4.tombstone_reanimation.python # flakey on sn-devel
^samba4.drs.delete_object.python.*.delete_object.DrsDeleteObjectTestCase.test_ReplicateDeletedObject1 # flakey on sn-devel
--
2.1.0
From 313b8bcd4ed7eb40e2f444f7ac718dc872a77257 Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Wed, 18 Mar 2015 17:41:42 +0100
Subject: [PATCH 2/2] selftet: fix the flapping entry for the drs.delete_object
test.
Signed-off-by: Michael Adam <obnox at samba.org>
---
selftest/flapping | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/selftest/flapping b/selftest/flapping
index 5e37a1b..0195487 100644
--- a/selftest/flapping
+++ b/selftest/flapping
@@ -26,4 +26,4 @@
^samba3.raw.samba3checkfsp.samba3checkfsp\(ad_dc\) # Seems to flap - succeeds on sn-devel, fails on Fedora 16
^samba3.raw.samba3closeerr.samba3closeerr\(ad_dc\) # Seems to flap - succeeds on sn-devel, fails on Fedora 16
^samba4.tombstone_reanimation.python # flakey on sn-devel
-^samba4.drs.delete_object.python.*.delete_object.DrsDeleteObjectTestCase.test_ReplicateDeletedObject1 # flakey on sn-devel
+^samba4.drs.delete_object.python # flakey on sn-devel
--
2.1.0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150318/bb937be1/attachment.pgp>
More information about the samba-technical
mailing list