[PATCH] Fix the O3 developer build

[Thomas Schulz]

> Am 16.03.2015 um 07:47 schrieb Volker Lendecke:
> > On Sun, Mar 15, 2015 at 10:53:07PM +0100, Stefan (metze) Metzmacher wro=
> te:
> >> Hi Volker,
> >>
> >>> Review&push appreciated!
> >>
> >> Can you split this into two commits?
> >>
> >> I'd also prefer '{}' instead of '{0}'.
> >>
> >> It seems '{0}' is not needed in the variable declaration.
> >=20
> > I'm not sure about that. I'd love to see the relevant
> > sections of the C standard before I am convinced. Do you
> > have pointers to that?
> 
> No. This is just what I learned from syntax error in
> source3/locking/brlock.c
> thread.
> 
> Thomas: Does struct torture_lease_break break_info_tmp =3D {}; work?

Sorry for the late reply. Yes, that works. The Solaris C compiler issues
a warning about a synatx error and the GNU C compiler does not complain.
Changing it to { 0 } eliminates the warning from the Solaris compiler
and does not cause any warnings from the GNU compiler.

 
> > Until then, I'll keep the patches
> > private, so that others are not bothered.
> >
> >> I'm also wondering if we should use -O3 for samba-ctdb in
> >> autobuild. The attached patch should do that, but it's not tested yet.=
> 
> >=20
> > That won't help much. Different gcc versions on different
> > platforms complain about different situations.
> 
> Sure, but preventing at least the common warnings seems to be better
> than preventing none.
> 
> > Attached find the uncontroversial part re-submitted.
> 
> Pushed.
> 
> Thanks!
> metze

Tom Schulz
Applied Dynamics Intl.
schulz at adi.com