[PATCH] mark tombstone_reanimation patch flapping

Michael Adam obnox at samba.org
Wed Mar 18 03:08:24 MDT 2015


Attached.

On 2015-03-18 at 09:25 +0100, Michael Adam wrote:
> On 2015-03-18 at 09:05 +0100, Stefan (metze) Metzmacher wrote:
> > Am 17.03.2015 um 23:07 schrieb Michael Adam:
> > > Hi,
> > > 
> > > it seems that the tombstone_reanimation test is the most
> > > prominent flapping test currently. I keeps us busy resubmitting
> > > autobuilds... Apparently the checks added in
> > > 72998acc451a8722f19b901a9948774de089921a fail randomly.
> > > 
> > > Can we mark this test flapping until this has been fixed?
> > 
> > Please include an example output of the failing autobuild into
> > the commit message.
> > 
> > Otherwise I'm fine with the change.
> 
> preparing...
> 
> > I'd also propose to add
> > samba4.drs.delete_object.python(promoted_dc)(promoted_dc)
> > 
> > See https://git.samba.org/autobuild.flakey/2015-03-18-0813/samba.stdout:
> 
> good point, preparing that as well...
> 
> Thanks - Michael
> 
> > [1692(11281)/1735 at 1h54m29s]
> > samba4.drs.delete_object.python(promoted_dc)(promoted_dc)
> > Testing for DrsDelObjUser_1426658948 with GUID
> > 80f07b62-7edd-4175-8e5c-f44b6081f39c
> > UNEXPECTED(failure):
> > samba4.drs.delete_object.python(promoted_dc).delete_object.DrsDeleteObjectTestCase.test_ReplicateDeletedObject1(promoted_dc)
> > REASON: Exception: Exception: Traceback (most recent call last):
> >   File "bin/python/samba/tests/__init__.py", line 113, in run
> >     testMethod()
> >   File
> > "/memdisk/autobuild/fl/b21901/samba/source4/torture/drs/python/delete_object.py",
> > line 214, in test_ReplicateDeletedObject1
> >     self._check_obj(sam_ldb=self.ldb_dc2, obj_orig=user_orig,
> > is_deleted=True)
> >   File
> > "/memdisk/autobuild/fl/b21901/samba/source4/torture/drs/python/delete_object.py",
> > line 82, in _check_obj
> >     self.assertEquals(name_cur, name_orig + "\nDEL:" + guid_str)
> > AssertionError: 'DrsDelObjUser_1426658948' !=
> > 'DrsDelObjUser_1426658948\nDEL:80f07b62-7edd-4175-8e5c-f44b6081f39c'
> > 
> > FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
> > 
> 
> 


-------------- next part --------------
From 21719d5f0c2bfc1d953572677c2e59bfb728bb0a Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Tue, 17 Mar 2015 23:00:03 +0100
Subject: [PATCH 1/2] selftest: the tombstone_reanimation test is currently
 flakey.

See
https://git.samba.org/autobuild.flakey/2015-03-18-0456/samba.stdout

[1657(10627)/1735 at 1h37m36s] samba4.tombstone_reanimation.python(fl2003dc)
Test Container reanimation
UNEXPECTED(failure): samba4.tombstone_reanimation.python.tombstone_reanimation.RestoreContainerObjectTestCase.test_container(fl2003dc)
REASON: Exception: Exception: Traceback (most recent call last):
  File "bin/python/samba/tests/__init__.py", line 113, in run
    testMethod()
  File "/memdisk/autobuild/fl/b2199/samba/source4/dsdb/tests/python/tombstone_reanimation.py", line 541, in test_container
    self.assertAttributesEqual(obj, attr_orig, obj_restore, attr_rest)
  File "/memdisk/autobuild/fl/b2199/samba/source4/dsdb/tests/python/tombstone_reanimation.py", line 86, in assertAttributesEqual
    self.assertEqual(attrs_orig, attrs_rest, "Actual object does not have expected attributes")
AssertionError: Actual object does not have expected attributes

FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)

There are more occurrences:

https://git.samba.org/autobuild.flakey/2015-03-17-1952/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-17-1350/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-16-0452/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-16-0156/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-15-1654/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-14-2253/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-14-1400/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-14-0153/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-13-2251/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-13-1059/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-13-0759/samba.stdout

Note that this fails in all environments it is configured to run in.

Signed-off-by: Michael Adam <obnox at samba.org>
---
 selftest/flapping | 1 +
 1 file changed, 1 insertion(+)

diff --git a/selftest/flapping b/selftest/flapping
index f039004..5f0b380 100644
--- a/selftest/flapping
+++ b/selftest/flapping
@@ -25,3 +25,4 @@
 ^samba3.raw.acls.inheritance\(ad_dc\) # Seems to flap - succeeds on sn-devel, fails on Fedora 16
 ^samba3.raw.samba3checkfsp.samba3checkfsp\(ad_dc\) # Seems to flap - succeeds on sn-devel, fails on Fedora 16
 ^samba3.raw.samba3closeerr.samba3closeerr\(ad_dc\) # Seems to flap - succeeds on sn-devel, fails on Fedora 16
+^samba4.tombstone_reanimation.python.tombstone_reanimation.RestoreContainerObjectTestCase.test_container # flakey on sn-devel
-- 
2.1.0


From 6eb455a535ba71107ca7cd38ead7c3bf459a3cef Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Wed, 18 Mar 2015 09:51:02 +0100
Subject: [PATCH 2/2] selftest: the drs.delete_object is currently flakey.

See
https://git.samba.org/autobuild.flakey/2015-03-18-0813/samba.stdout

[1692(11281)/1735 at 1h54m29s] samba4.drs.delete_object.python(promoted_dc)(promoted_dc)
Testing for DrsDelObjUser_1426658948 with GUID 80f07b62-7edd-4175-8e5c-f44b6081f39c
UNEXPECTED(failure): samba4.drs.delete_object.python(promoted_dc).delete_object.DrsDeleteObjectTestCase.test_ReplicateDeletedObject1(promoted_dc)
REASON: Exception: Exception: Traceback (most recent call last):
  File "bin/python/samba/tests/__init__.py", line 113, in run
    testMethod()
  File "/memdisk/autobuild/fl/b21901/samba/source4/torture/drs/python/delete_object.py", line 214, in test_ReplicateDeletedObject1
    self._check_obj(sam_ldb=self.ldb_dc2, obj_orig=user_orig, is_deleted=True)
  File "/memdisk/autobuild/fl/b21901/samba/source4/torture/drs/python/delete_object.py", line 82, in _check_obj
    self.assertEquals(name_cur, name_orig + "\nDEL:" + guid_str)
AssertionError: 'DrsDelObjUser_1426658948' != 'DrsDelObjUser_1426658948\nDEL:80f07b62-7edd-4175-8e5c-f44b6081f39c'

FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)

There are many more occurrences:

https://git.samba.org/autobuild.flakey/2013-08-02-1537/samba.stdout
https://git.samba.org/autobuild.flakey/2013-08-04-1536/samba.stdout
https://git.samba.org/autobuild.flakey/2013-08-05-0336/samba.stdout
https://git.samba.org/autobuild.flakey/2013-08-09-1141/samba.stdout
https://git.samba.org/autobuild.flakey/2013-08-13-1537/samba.stdout
https://git.samba.org/autobuild.flakey/2013-08-14-0936/samba.stdout
https://git.samba.org/autobuild.flakey/2013-08-14-1736/samba.stdout
https://git.samba.org/autobuild.flakey/2013-08-15-1936/samba.stdout
...
https://git.samba.org/autobuild.flakey/2014-05-01-1707/samba.stdout
https://git.samba.org/autobuild.flakey/2014-05-03-1411/samba.stdout
https://git.samba.org/autobuild.flakey/2014-05-03-1710/samba.stdout
https://git.samba.org/autobuild.flakey/2014-05-04-1710/samba.stdout
https://git.samba.org/autobuild.flakey/2014-05-13-0507/samba.stdout
https://git.samba.org/autobuild.flakey/2014-05-23-1113/samba.stdout
https://git.samba.org/autobuild.flakey/2014-05-29-0213/samba.stdout
https://git.samba.org/autobuild.flakey/2014-06-02-0513/samba.stdout
https://git.samba.org/autobuild.flakey/2014-06-08-1713/samba.stdout
https://git.samba.org/autobuild.flakey/2014-06-09-0512/samba.stdout
https://git.samba.org/autobuild.flakey/2014-06-14-0214/samba.stdout
...
https://git.samba.org/autobuild.flakey/2015-03-02-0213/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-02-0813/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-03-0513/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-04-0811/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-07-1113/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-07-1713/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-08-2013/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-09-0813/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-09-2008/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-12-0807/samba.stdout

Signed-off-by: Michael Adam <obnox at samba.org>
---
 selftest/flapping | 1 +
 1 file changed, 1 insertion(+)

diff --git a/selftest/flapping b/selftest/flapping
index 5f0b380..17f5048 100644
--- a/selftest/flapping
+++ b/selftest/flapping
@@ -26,3 +26,4 @@
 ^samba3.raw.samba3checkfsp.samba3checkfsp\(ad_dc\) # Seems to flap - succeeds on sn-devel, fails on Fedora 16
 ^samba3.raw.samba3closeerr.samba3closeerr\(ad_dc\) # Seems to flap - succeeds on sn-devel, fails on Fedora 16
 ^samba4.tombstone_reanimation.python.tombstone_reanimation.RestoreContainerObjectTestCase.test_container # flakey on sn-devel
+^samba4.drs.delete_object.python.*.delete_object.DrsDeleteObjectTestCase.test_ReplicateDeletedObject1 # flakey on sn-devel
-- 
2.1.0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150318/b87eb3ca/attachment.pgp>


More information about the samba-technical mailing list