[PATCH] Fix the O3 developer build
Stefan (metze) Metzmacher
metze at samba.org
Mon Mar 16 16:17:19 MDT 2015
Am 16.03.2015 um 07:47 schrieb Volker Lendecke:
> On Sun, Mar 15, 2015 at 10:53:07PM +0100, Stefan (metze) Metzmacher wrote:
>> Hi Volker,
>>
>>> Review&push appreciated!
>>
>> Can you split this into two commits?
>>
>> I'd also prefer '{}' instead of '{0}'.
>>
>> It seems '{0}' is not needed in the variable declaration.
>
> I'm not sure about that. I'd love to see the relevant
> sections of the C standard before I am convinced. Do you
> have pointers to that?
No. This is just what I learned from syntax error in
source3/locking/brlock.c
thread.
Thomas: Does struct torture_lease_break break_info_tmp = {}; work?
> Until then, I'll keep the patches
> private, so that others are not bothered.
>
>> I'm also wondering if we should use -O3 for samba-ctdb in
>> autobuild. The attached patch should do that, but it's not tested yet.
>
> That won't help much. Different gcc versions on different
> platforms complain about different situations.
Sure, but preventing at least the common warnings seems to be better
than preventing none.
> Attached find the uncontroversial part re-submitted.
Pushed.
Thanks!
metze
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150316/85062a12/attachment.pgp>
More information about the samba-technical
mailing list