[PATCHES] rename some test envs

Andrew Bartlett abartlet at samba.org
Mon Mar 16 14:26:32 MDT 2015


On Mon, 2015-03-16 at 20:55 +0100, Michael Adam wrote:
> On 2015-03-17 at 08:46 +1300, Andrew Bartlett wrote:
> > On Mon, 2015-03-16 at 09:09 +0100, Michael Adam wrote:
> > > On 2015-03-16 at 14:51 +1300, Andrew Bartlett wrote:
> > > > On Tue, 2015-03-10 at 23:51 +0100, Michael Adam wrote:
> > > > > Hi,
> > > > > 
> > > > > attached find a patchset that renames a few
> > > > > of our testenvs in a more systematic and
> > > > > understandable way.
> > > > > 
> > > > > Andrew, please note that I have changed the
> > > > > renames slightly from your original proposal
> > > > > after discussing at some length with Günther.
> > > > 
> > > > This failed an autobuild with:
> > > > 
> > > > > 
> > > > > UNEXPECTED(failure): samba4.blackbox.pkinit(ad_dc_ntvfs:local).kinit
> > > > > with pkinit (name specified)(ad_dc_ntvfs:local) 
> > > > > REASON: Exception: Exception: samba4kinit: krb5_get_init_creds_opt_set_pkinit: Failed to init cert certs: Failed to open PEM file "./bin/ab/dc/private/tls/admincert.pem": No such file or directory
> > > > > 
> > > > > FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
> > > > > 
> > > > > A summary with detailed information can be found in:
> > > > >   ./bin/ab/summary
> > > > 
> > > > There will be more issues like this - the test env names are encoded in
> > > > other places for sure.  Can you get this past a full autobuild, and then
> > > > get it back to me?
> > > 
> > > Hmm strange. I actually did that and I think I fixed this issue,
> > > but maybe I have attached the wrong version of the patchset.
> > > Sorry for that! - I will follow up.
> > 
> > If you can do that using variables for the environment names (as should
> > have been done in the first place, sorry), that would be great.
> 
> If you have missed my other mail in this thread from 1.5 hours
> ago I have solved that even more better (imho) by changing the
> meaning of the handed in PREFIX for these tests to mean the
> environment's subdirectory of the selftest prefix dir, with the
> positive side effect that these blackbox test scripts don't
> clutter the main st directory with their temporary data...

Yes, I thought my mail queue was a bit light, and so I re-started the
fetchmail :-)

I've pushed those, they look good!

> > BTW, the other rename thing we need to do is getting rid of the 'binary
> > name mapping' hack I added to cope with our different build systems and
> > choices of names.
> 
> Feel free to send a patch. ;)

:-)

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150317/f63e3b9c/attachment.pgp>


More information about the samba-technical mailing list