[PATCH] FS_SECTOR_SIZE_INFORMATION and FSCTL_FILE_LEVEL_TRIM

David Disseldorp ddiss at suse.de
Mon Mar 16 09:19:23 MDT 2015


On Sun, 15 Mar 2015 05:08:43 -0700, Christoph Hellwig wrote:

> At least for Linux local filesytems you should report the actual
> underlying sector size (which unfortunately is rather cumbersome)
> instead of makign values up.  The reason why the protocol reports the
> sector size is because it has data integrity implications.

Yes, we're currently returning hard-coded sector size information via
many of the filesystem query-info levels. This should be determined at
runtime, in addition to the SSINFO_FLAGS_NO_SEEK_PENALTY and
SSINFO_FLAGS_TRIM_ENABLED flags.

I expect we can set the latter based on FITRIM availability at build
time. NO_SEEK_PENALTY is going to be tough without reaching into
/sys/block.


More information about the samba-technical mailing list