[PATCH] lib/util: Include DEBUG macro in internal header files before samba_util.h

Lukas Slebodnik lslebodn at redhat.com
Mon Mar 16 03:23:48 MDT 2015


On (11/03/15 08:01), Jeremy Allison wrote:
>On Wed, Mar 11, 2015 at 02:28:50PM +1100, Martin Schwenke wrote:
>> On Tue, 10 Mar 2015 14:10:59 +0100, Andreas Schneider <asn at samba.org>
>> wrote:
>> 
>> > On Thursday 05 March 2015 11:41:12 Lukas Slebodnik wrote:
>> > > ehlo,
>> > > 
>> > > It's best practice to include external header files before internal
>> > > header files. In this case internal DEBUG macro cannot be defined and
>> > > therefore samba version of debug macro will be included
>> > > in header file "util/fault.h".
>> > > 
>> > > Attached patch is additional fix for
>> > >  https://bugzilla.samba.org/show_bug.cgi?id=11033
>> > > 
>> > > LS
>> > 
>> > Looks good to me, we need a second reviewer for this.
>> 
>> Reviewed-by: Martin Schwenke <martin at meltin.net>
>
>Pushed to autobuild.

Thank you very much.

Would it be possible to push patch to stable branch(4.2) as well?
or will master become 4.3 in near future?

LS


More information about the samba-technical mailing list