[PATCH] Handle SIGCHLD better in process_standard, remove process_{onefork,prefork}

Andrew Bartlett abartlet at samba.org
Sun Mar 15 20:02:45 MDT 2015

On Mon, 2015-03-02 at 17:14 +1300, Andrew Bartlett wrote:
> Attached is a patch set to properly handle SIGCHLD in process_standard
> in the source4/ code, and in doing so ensure we catch errors from
> samba_kcc and samba_dnsupdate.
> Metze,
> Can you look over this and if you are happy, review/push?  I would like
> to have tests for a change like this, so if you have any good ideas
> about how to do that, please let me know.  I've tested it manually by
> killing off children with kill -9, and natrually the success case will
> be covered well in autobuild. 
> Also, what do you think about removing process_prefork and
> process_onefork?  I added them both - prefork I did as an exercise to
> teach ddiss Samba4 development, and I can't remember why I did onefork -
> I think it may have been for ideas around s3compat.  As far as I can
> tell they are unused, but could in theory be invoked from the command
> line. 
> Otherwise, they would need to be rewritten to use some common lib code
> with process_standard. 


Can I please get a review of the first of the patches I attached,
re-attached here?  The others Jelmer has kindly reviewed, but are not
much point until I can fix up process_standard and SIGCHLD.


Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-process_standard-Remove-signal-SIGCHLD-SIG_IGN.patch
Type: text/x-patch
Size: 6540 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150316/fb536aa5/attachment.bin>

More information about the samba-technical mailing list