[PATCH] Fix the O3 developer build

Stefan (metze) Metzmacher metze at samba.org
Sun Mar 15 15:53:07 MDT 2015

Hi Volker,

> Review&push appreciated!

Can you split this into two commits?

I'd also prefer '{}' instead of '{0}'.

It seems '{0}' is not needed in the variable declaration.

I'm also wondering if we should use -O3 for samba-ctdb in
autobuild. The attached patch should do that, but it's not tested yet.

-------------- next part --------------
From e132b26b2c7f9d955fad22f8c5b9996796b22219 Mon Sep 17 00:00:00 2001
From: Stefan Metzmacher <metze at samba.org>
Date: Sun, 15 Mar 2015 22:49:20 +0100
Subject: [PATCH] script/autobuild.py: use for ADDITIONAL_CFLAGS='-O3' for

Signed-off-by: Stefan Metzmacher <metze at samba.org>
 script/autobuild.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/script/autobuild.py b/script/autobuild.py
index 6fcdcd4..100990d 100755
--- a/script/autobuild.py
+++ b/script/autobuild.py
@@ -54,13 +54,13 @@ tasks = {
     "samba-ctdb" : [ ("random-sleep", "script/random-sleep.sh 60 600", "text/plain"),
                      # make sure we have tdb around:
-                     ("tdb-configure", "cd lib/tdb && PYTHONPATH=${PYTHON_PREFIX}/site-packages:$PYTHONPATH PKG_CONFIG_PATH=$PKG_CONFIG_PATH:${PREFIX_DIR}/lib/pkgconfig ./configure --bundled-libraries=NONE --abi-check --enable-debug -C ${PREFIX}", "text/plain"),
+                     ("tdb-configure", "cd lib/tdb && PYTHONPATH=${PYTHON_PREFIX}/site-packages:$PYTHONPATH PKG_CONFIG_PATH=$PKG_CONFIG_PATH:${PREFIX_DIR}/lib/pkgconfig ADDITIONAL_CFLAGS='-O3' ./configure --bundled-libraries=NONE --abi-check --enable-debug -C ${PREFIX}", "text/plain"),
                      ("tdb-make", "cd lib/tdb && make", "text/plain"),
                      ("tdb-install", "cd lib/tdb && make install", "text/plain"),
                      # build samba with cluster support (also building ctdb):
-                     ("samba-configure", "PYTHONPATH=${PYTHON_PREFIX}/site-packages:$PYTHONPATH PKG_CONFIG_PATH=${PREFIX_DIR}/lib/pkgconfig:${PKG_CONFIG_PATH} ./configure.developer --picky-developer ${PREFIX} --with-selftest-prefix=./bin/ab --with-cluster-support --bundled-libraries=!tdb", "text/plain"),
+                     ("samba-configure", "PYTHONPATH=${PYTHON_PREFIX}/site-packages:$PYTHONPATH PKG_CONFIG_PATH=${PREFIX_DIR}/lib/pkgconfig:${PKG_CONFIG_PATH} ADDITIONAL_CFLAGS='-O3' ./configure.developer --picky-developer ${PREFIX} --with-selftest-prefix=./bin/ab --with-cluster-support --bundled-libraries=!tdb", "text/plain"),
                      ("samba-make", "make", "text/plain"),
                      ("samba-check", "./bin/smbd -b | grep CLUSTER_SUPPORT", "text/plain"),
                      ("samba-install", "make install", "text/plain"),

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150315/ce6a1ce3/attachment.pgp>

More information about the samba-technical mailing list