[PATCH] idl: define FSCTL_DUPLICATE_EXTENTS_TO_FILE

Tom Talpey ttalpey at microsoft.com
Sat Mar 14 11:04:47 MDT 2015


> -----Original Message-----
> From: samba-technical-bounces at lists.samba.org [mailto:samba-technical-
> bounces at lists.samba.org] On Behalf Of David Disseldorp
> Sent: Wednesday, March 11, 2015 4:19 AM
> To: Jeremy Allison
> Cc: samba-technical at lists.samba.org
> Subject: Re: [PATCH] idl: define FSCTL_DUPLICATE_EXTENTS_TO_FILE
> 
> On Tue, 10 Feb 2015 14:17:21 +0100, David Disseldorp wrote:
> 
> > > > It should be accessible from:
> > > > http://download.microsoft.com/download/C/6/C/C6C3C6F1-E84A-
> 44EF-82
> > > > A9-49BD3AAD8F58/Windows/%5BMS-FSCC-Diff%5D.pdf
> > > >
> > > > Thanks for the review!
> > >
> > > Sorry, looking at this and the thing that I don't get is the:
> > >
> > >  uint8 source_handle[8];
> > >
> > > that doesn't seem like a handle
> > > to me, or am I mixing stuff up ?
> > >
> > > I don't see the on the wire definitions of this new IOCTL in the
> > > FSCC doc, only the algorithm description.
> >
> > MS-FSCC-Diff section 2.3.7 defines the
> FSCTL_DUPLICATE_EXTENTS_TO_FILE
> > request payload as having an eight-byte FileHandle field, so I just
> > mapped that to an opaque array for now.
> 
> I'll resend this patch with a change to indicate that the FileHandle field is the
> volatile part of the fileid, as mentioned by Tom.

FYI, we're updating the doc for the next Preview. Sorry for the partial content, and thanks for the observation!

Tom.


More information about the samba-technical mailing list