[PATCH] samdb: Add NULL checks

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Mar 13 04:12:31 MDT 2015


Hi!

Review&push appreciated!

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From f8b074effdb9b96858f50205e16fa4114ebe7925 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Thu, 12 Mar 2015 12:40:59 +0000
Subject: [PATCH] samdb: Add NULL checks

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source4/dsdb/samdb/ldb_modules/secrets_tdb_sync.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/source4/dsdb/samdb/ldb_modules/secrets_tdb_sync.c b/source4/dsdb/samdb/ldb_modules/secrets_tdb_sync.c
index 7307f27..00f7975 100644
--- a/source4/dsdb/samdb/ldb_modules/secrets_tdb_sync.c
+++ b/source4/dsdb/samdb/ldb_modules/secrets_tdb_sync.c
@@ -497,11 +497,17 @@ static int secrets_tdb_sync_init(struct ldb_module *module)
 		secrets_ldb += 6;
 	}
 	private_dir = talloc_strdup(data, secrets_ldb);
+	if (private_dir == NULL) {
+		return ldb_oom(ldb);
+	}
 	p = strrchr(private_dir, '/');
 	if (p) {
 		*p = '\0';
 	} else {
 		private_dir = talloc_strdup(data, ".");
+		if (private_dir == NULL) {
+			return ldb_oom(ldb);
+		}
 	}
 
 	/* If there's an ntdb file, force code to load that. */
-- 
1.9.1



More information about the samba-technical mailing list