[PATCH] pidl/Python: don't assume presence of client header

David Disseldorp ddiss at suse.de
Thu Mar 12 04:43:45 MDT 2015

Thanks for the feedback Jelmer...

On Wed, 11 Mar 2015 19:53:27 +0100, Jelmer Vernooij wrote:

> On Wed, Mar 11, 2015 at 07:39:41PM +0100, David Disseldorp wrote:
> > As of c660845737f454713f60f01d015125b053435b2c, the PIDL Python back-end
> > unconditionally includes the client NDR header, regardless of whether it
> > was generated by PIDL via --client or not.
> > 
> > This change sees the Python back-end only include the corresponding
> > client NDR header if PIDL is run with --client.
> Some users of pidl run it separately for each file to generate - e.g. once with
> --client and once with --python. Won't this break them?

Which users? I haven't been able to find such (IMO broken) use cases in
Samba, but may be looking in the wrong place.

Given that the initial regression was introduced to fix warnings in the
generated code, I'm not so sure it'd cause breakage.

Cheers, David

More information about the samba-technical mailing list