syntax error in source3/locking/brlock.c

Christof Schmitt cs at samba.org
Wed Mar 11 13:28:49 MDT 2015


On Wed, Mar 11, 2015 at 06:53:44PM +0100, Michael Adam wrote:
> Thanks!
> 
> If Christof is happy with the partial patch,
> I am hereby granting my reviewed-by.

Yes, i will provide a patch just for the one instance. As mentioned
earlier, we should defer all the other changes until gcc no longer
prints the warnings.

Thanks for the reviewed-by, i will add it to the patch.

Christof

> 
> Michael
> 
> On 2015-03-11 at 11:47 -0400, Thomas Schulz wrote:
> > > > Agreed.
> > > > 
> > > > Interestingly, this bug was already discussed in this thread
> > > > 
> > > > https://lists.samba.org/archive/samba-technical/2015-February/105624.html
> > > > 
> > > > =66rom Feb 18, and I proposed the same change in
> > > > 
> > > > https://lists.samba.org/archive/samba-technical/2015-February/105625.html
> > > > 
> > > > but the original reporter never came up with a git-patch
> > > > and I lost track of it.
> > > > 
> > > > 
> > > > Michael
> > > 
> > > Oh goodness! I was just thinking that I should open a Bug report and attach
> > > the required part of the patch by Christof. I will do that tomorrow unless
> > > I hear otherwise.
> > 
> > Filed bug 11153.
> > 
> > Tom Schulz
> > Applied Dynamics Intl.
> > schulz at adi.com




More information about the samba-technical mailing list