[PATCH] Coverity fixes

[Ira Cooper]

Reviewed and pushed again... we'll see how it goes.

Reviewed-by: Ira Cooper <ira at samba.org>

-Ira

On Mon, Mar 9, 2015 at 6:27 AM, Volker Lendecke <Volker.Lendecke at sernet.de>
wrote:

> On Sun, Mar 08, 2015 at 05:10:48PM -0400, Ira Cooper wrote:
> > On Sun, Mar 8, 2015 at 2:40 PM, Volker Lendecke <
> Volker.Lendecke at sernet.de>
> > wrote:
> >
> > > On Sat, Mar 07, 2015 at 07:05:32PM -0500, Ira Cooper wrote:
> > > > I tried to push this patchset.  It is causing random failures, or
> I've
> > > > gotten lucky on my last two pushes without it, and "unlucky" on
> these.
> > > >
> > > > I'll give this some more thought.  But for now: NAK, due to fail.
> > >
> > > /memdisk on sn-devel has
> > >
> > > /dev/loop7             38G   15G 22G  41% /memdisk
> > >
> > > with just one autobuild running. Maybe boot sn-devel? This
> > > led to problems in the past. One of my recent completely
> > > innocent fixes took 4 attempts to finally get through.
> > >
> >
> > Strangely, I pushed Richard Sharpe's change last night.. and it went
> > through.  So I'm still suspicious.
> >
> > I'll leave the reboot work to those actually doing the work.
> >
> > In the changes, the only one I can come up with making a difference is
> the
> > ldb one.  Which we'd both hope wouldn't cause issues.
>
> The attached patchset just survived a private autobuild on sn-devel for
> me. It contains the NACKed patchset with some additional but unrelated
> Coverity fixes on top. I can't really prove the successful autobuild,
> I guess you just have to trust me on this.
>
> Comments?
>
> With best regards,
>
> Volker Lendecke
>
> --
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de, mailto:kontakt at sernet.de
>