[PATCH] ctdb-locking: Back-off from logging every 10 seconds
martin at meltin.net
Tue Mar 10 04:44:05 MDT 2015
On Tue, 10 Mar 2015 10:54:22 +0100, Volker Lendecke
<Volker.Lendecke at SerNet.DE> wrote:
> On Mon, Mar 09, 2015 at 07:09:12PM +1100, Martin Schwenke wrote:
> > On Fri, 6 Mar 2015 22:55:42 +1100, Martin Schwenke <martin at meltin.net>
> > wrote:
> > > On Thu, 5 Mar 2015 12:39:40 +0100, Volker Lendecke
> > > <Volker.Lendecke at SerNet.DE> wrote:
> > >
> > > > On Thu, Mar 05, 2015 at 10:29:27PM +1100, Martin Schwenke wrote:
> > > > > I don't think you want the 2nd patch. debug_locks is static. The environment variable can't change so we cache the value in the static. We do that in a few places.
> > > >
> > > > Hmm. Ok. But is talloc off ctdb the right thing then? If the
> > > > string goes away, "debug_locks" will have a bogus pointer.
> > > > This won't happen probably, but it is still confusing. At
> > > > least it confused me.
> > >
> > > Good point. I have the perfect way of making this much, much clearer.
> > > Patch soon... :-)
> > How about this? We do the same thing 3 times so might as well use a
> > helper function and test some extra things...
> > Review and push appreciated.
> Looks good, but it does not apply to master (c6cb2d6) for
> me. Do you have a git repo available with this patch?
Sorry, some other patches in my queue cause the breakage. I should
always cherry-pick onto a clean branch before posting. :-(
I've cherry-picked them into a ctdb-misc branch (in
peace & happiness,
More information about the samba-technical