[PATCH] ctdb-locking: Back-off from logging every 10 seconds

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Mar 10 03:54:22 MDT 2015


On Mon, Mar 09, 2015 at 07:09:12PM +1100, Martin Schwenke wrote:
> On Fri, 6 Mar 2015 22:55:42 +1100, Martin Schwenke <martin at meltin.net>
> wrote:
> 
> > On Thu, 5 Mar 2015 12:39:40 +0100, Volker Lendecke
> > <Volker.Lendecke at SerNet.DE> wrote:
> > 
> > > On Thu, Mar 05, 2015 at 10:29:27PM +1100, Martin Schwenke wrote:
> 
> > > > I don't think you want the 2nd patch. debug_locks is static.  The environment variable can't change so we cache the value in the static.  We do that in a few places. 
> > > 
> > > Hmm. Ok. But is talloc off ctdb the right thing then? If the
> > > string goes away, "debug_locks" will have a bogus pointer.
> > > This won't happen probably, but it is still confusing. At
> > > least it confused me.
> > 
> > Good point.  I have the perfect way of making this much, much clearer.
> > Patch soon...  :-)
> 
> How about this?  We do the same thing 3 times so might as well use a
> helper function and test some extra things...
> 
> Review and push appreciated.

Looks good, but it does not apply to master (c6cb2d6) for
me. Do you have a git repo available with this patch?

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list