[PATCH] ctdb-locking: Back-off from logging every 10 seconds

Martin Schwenke martin at meltin.net
Mon Mar 9 02:09:12 MDT 2015

On Fri, 6 Mar 2015 22:55:42 +1100, Martin Schwenke <martin at meltin.net>

> On Thu, 5 Mar 2015 12:39:40 +0100, Volker Lendecke
> <Volker.Lendecke at SerNet.DE> wrote:
> > On Thu, Mar 05, 2015 at 10:29:27PM +1100, Martin Schwenke wrote:

> > > I don't think you want the 2nd patch. debug_locks is static.  The environment variable can't change so we cache the value in the static.  We do that in a few places. 
> > 
> > Hmm. Ok. But is talloc off ctdb the right thing then? If the
> > string goes away, "debug_locks" will have a bogus pointer.
> > This won't happen probably, but it is still confusing. At
> > least it confused me.
> Good point.  I have the perfect way of making this much, much clearer.
> Patch soon...  :-)

How about this?  We do the same thing 3 times so might as well use a
helper function and test some extra things...

Review and push appreciated.

peace & happiness,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctdb.patches
Type: application/octet-stream
Size: 7309 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150309/984f5113/attachment.obj>

More information about the samba-technical mailing list