Using python-pexpect...

[Andrew Bartlett]

On Mon, 2015-03-09 at 20:37 +1300, Andrew Bartlett wrote:
> On Thu, 2015-01-29 at 22:50 +0100, Jelmer Vernooij wrote:
> > On Thu, Jan 29, 2015 at 09:12:37AM +0100, Stefan (metze) Metzmacher wrote:
> > > Hi Jelmer,
> > > 
> > > >> I'd like to use python-pexpect for some tests,
> > > >> it seems much more powerful than our texpect tool.
> > > >>
> > > >> Could you prepare the third_party import for me?
> > > > Sure. What's the upstream URL?
> > > 
> > > See https://github.com/pexpect/pexpect
> > > 
> > > I hope the license http://opensource.org/licenses/isc-license.txt
> > > is fine for us.
> > > 
> > > The current versions seem to require Python 2.6,
> > > would that be ok for things used in make test?
> > > 
> > > Here's the url to the repo:
> > > https://github.com/pexpect/pexpect.git
> > 
> > Sent out a patchset. Please review and push.
> > 
> > Also available on git://git.samba.org/jelmer/samba.git, branch
> > for-review/pexpect.
> 
> Jelmer,
> 
> I was thinking to review this for you, but it seems to be importing it
> into lib/ and not third_party, but the patch in [PATCH 2/3] Add support
> for updating pexpect wants to put it in third_party.
> 
> Can you rebase on master, fix this and and re-propose as a branch (large
> git mails for imports like this just choke up my mailer, unless they are
> attachments)

Sorry, I didn't look closely enough at the patches.  The activity in
lib/ is because that commit updates many other libraries at the same
time.  This probably starts to go back over the git submodules
dicussion, but we need to tag exactly which upstream revision we are
updating to, so the results can be repeated (and therefore independently
verified). 

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba