[PATCH] winbind: Make wb_sids2xids_recv work on an array

David Disseldorp ddiss at suse.de
Fri Mar 6 06:43:21 MST 2015

On Fri, 6 Mar 2015 11:35:47 +0100, Volker Lendecke wrote:

> -	status = wb_sids2xids_recv(subreq, state->xids);
> +	status = wb_sids2xids_recv(subreq, state->xids,
> +				   talloc_array_length(state->xids));

Might be unnecessary optimisation, but these talloc_array_length()
calculations could be avoided by using the length used with the
allocation. Would you consider squashing on the attached patch?

Reviewed-by: David Disseldorp <ddiss at samba.org>

Cheers, David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-SQUASH-avoid-calculating-talloc-array-length-when-al.patch
Type: text/x-patch
Size: 1604 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150306/b2882038/attachment.bin>

More information about the samba-technical mailing list